| To: | xfs-dev <xfs-dev@xxxxxxx> |
|---|---|
| Subject: | Review: do not hold dm_reg_lock spinlock when calling dm_add_fsys_entry() |
| From: | Vlad Apostolov <vapo@xxxxxxx> |
| Date: | Fri, 30 Mar 2007 11:34:21 +1000 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 1.5.0.10 (X11/20070221) |
Attached is a fix. Regards, Vlad Index: linux/fs/dmapi/dmapi_register.c
===================================================================
--- linux.orig/fs/dmapi/dmapi_register.c
+++ linux/fs/dmapi/dmapi_register.c
@@ -252,6 +252,7 @@ dm_add_fsys_entry(
fsrp->fr_next = dm_registers;
dm_registers = fsrp;
dm_fsys_cnt++;
+ mutex_spinunlock(&dm_reg_lock, lc);
#ifdef CONFIG_PROC_FS
{
char buf[100];
@@ -262,7 +263,6 @@ dm_add_fsys_entry(
entry->owner = THIS_MODULE;
}
#endif
- mutex_spinunlock(&dm_reg_lock, lc);
return(0);
}
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Review: Make xfs_dm_sync_by_handle really sync data, Vlad Apostolov |
|---|---|
| Next by Date: | TAKE 962866 - sleeping in atomic in dmapi, Vlad Apostolov |
| Previous by Thread: | TAKE attr translations - Spanish and Galician, Tim Shimmin |
| Next by Thread: | TAKE 962866 - sleeping in atomic in dmapi, Vlad Apostolov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |