Re: [PATCH] remove unused filp from ioctl functions

xfs

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH] remove unused filp from ioctl functions
From:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Date:	Sat, 11 Nov 2006 11:12:35 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20061111105627.GB3356@infradead.org>
References:	<4555437B.4040904@sandeen.net> <20061111105627.GB3356@infradead.org>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Thunderbird 1.5.0.8 (Macintosh/20061025)

Christoph Hellwig wrote:

On Fri, Nov 10, 2006 at 09:28:59PM -0600, Eric Sandeen wrote:

There's a stuct file * passed around the ioctl code that is never
used... just takes up precious stack space near as I can tell :)


While you're at it kill the inode paramater anyway, it can be retrieved
from the vnode by trivial address arithmetics.


Hadn't noticed, let me look into that.

-Eric

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] remove unused filp from ioctl functions, Eric Sandeen Re: [PATCH] remove unused filp from ioctl functions, Christoph Hellwig Re: [PATCH] remove unused filp from ioctl functions, Eric Sandeen <=

Previous by Date:	Re: [PATCH] remove unused filp from ioctl functions, Christoph Hellwig
Next by Date:	Re: XFS Update for 2.6.19 - take 2, Vlad Apostolov
Previous by Thread:	Re: [PATCH] remove unused filp from ioctl functions, Christoph Hellwig
Next by Thread:	[PATCH] remove unused xflags parameter from sync routines, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]