xfs
[Top] [All Lists]

Re: review: greedy allocator vs kmflags

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: review: greedy allocator vs kmflags
From: Vlad Apostolov <vapo@xxxxxxx>
Date: Mon, 28 Aug 2006 17:00:28 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20060828163004.B3100886@wobbly.melbourne.sgi.com>
References: <20060828163004.B3100886@wobbly.melbourne.sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.5 (X11/20060719)
Nathan Scott wrote:
Hi Vlad,

This is the last iteration on updating the greedy alloc routine to
be more generic and properly handle the passed in flags wrt sleep or
nosleep (following up on Dave's suggestion, and someone else to me
privately, offlist).  Could you give it a final review for me?

thanks.

It is looking good Nathan. One thing I noticed today when I was building the modules
was that kmem_zalloc_greedy() is already in use in several places. There
were a few warnings about type mismatch of the first argument "size_t *size" and
missing kmem_zalloc_greedy symbol at the end. Not sure if this is important but just
thought to mention it.


Regards,
Vlad


<Prev in Thread] Current Thread [Next in Thread>
  • Re: review: greedy allocator vs kmflags, Vlad Apostolov <=