xfs
[Top] [All Lists]

Re: [RFD] FS behavior (I/O failure) in kernel summit

To: Dave Chinner <dgc@xxxxxxx>
Subject: Re: [RFD] FS behavior (I/O failure) in kernel summit
From: Jeff Mahoney <jeffm@xxxxxxxx>
Date: Thu, 16 Jun 2005 11:21:11 -0400
Cc: Hans Reiser <reiser@xxxxxxxxxxx>, fs <fs@xxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, viro VFS <viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, zhiming@xxxxxxxxxxxxxxxxx, qufuping@xxxxxxxxxxxxxxxxxx, madsys@xxxxxxxxxxxxxxxxxx, xuh@xxxxxxxxxxxxxx, koichi@xxxxxxxxxxxxxxxxx, kuroiwaj@xxxxxxxxxxxxxxxxx, okuyama@xxxxxxxxxxxxxxxxx, matsui_v@xxxxxxxxxxxxx, kikuchi_v@xxxxxxxxxxxxx, fernando@xxxxxxxxxxxxxxxxx, kskmori@xxxxxxxxxxxxxxxxx, takenakak@xxxxxxxxxxxxxxxxx, yamaguchi@xxxxxxxxxxxxxxxxx, ext2-devel@xxxxxxxxxxxxxxxxxxxxx, sct@xxxxxxxxxx, shaggy@xxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx, Reiserfs developers mail-list <Reiserfs-Dev@xxxxxxxxxxx>
In-reply-to: <20050616121822.E125706@melbourne.sgi.com>
References: <1118692436.2512.157.camel@CoolQ> <42ADC99D.5000801@namesys.com> <42ADFFD5.1090905@suse.com> <42AE1EE4.5090508@namesys.com> <42B067B6.9030009@suse.com> <20050616121822.E125706@melbourne.sgi.com>
Sender: linux-xfs-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0 (X11/20041207)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dave Chinner wrote:
>>Well it seems to me that all the XFS code does is check to see if the FS
>>is in a shutdown state really early in the call path.
> 
> FYI, the up front checks in XFS are simply to stop new I/O from starting
> if we're already in the shutdown state.
> 
> However, there's more than that in XFS - there's checks all through
> it's I/O paths so that I/Os and transactions in flight at (or
> started after) the time of the shutdown can be aborted before doing
> further damage to a potentially corrupted filesystem. This part
> cannot be done generically as it is intimately tied to the
> filesystem.
> 
> It is also worth noting that XFS won't shutdown a filesystem on just
> any I/O error. Shutdowns due to I/O errors only occur when the
> failure has the potential to leave the filesystem in an inconsistent
> state.  Hence any given operation can return different errors
> depending on where the I/O error occurred in XFS and what effect
> that I/O error has on the consistency of the filesystem.....

Sorry, I should have clarified. I was only refering to the handling of
operations that aren't already in flight.

Currently, ReiserFS (and ext3) will set the filesystem read-only on
error, which ends up returning -EROFS in situations where that error
code is correct, but not entirely appropriate.

- -Jeff

- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCsZjnLPWxlyuTD7IRAuk5AKCplbYsl3YFml9/M1GRtuvBz21jvwCgoWKn
Mpl0khchSkQ1RwI/mkZ8buY=
=DxvJ
-----END PGP SIGNATURE-----


<Prev in Thread] Current Thread [Next in Thread>