Dean Roehrich a écrit:
From: Aurelien Degremont - Stagiaire <degremont@xxxxxxxxxxx>
Here is a very small patch that change the parameter of fh_to_inode()
and inode_to_fh().
I just replace the dm_fsfid_t by a dm_fid_t.
I've been using your patch today. So far it's good.
Here's the rest of it, to completely remove dm_fsfid. Do these
dm_copyin_handle() changes look right to you?
It was really a good idea to fix this since I found, in the dmapi user
space library, in the parse_handle() function, that you copy the opaque
buffer ha_fid in a xfs_fid2_t structure (argh ! an xfs reference in a
code which is supposed to be independent :)). And from this xfs_fid2,
the igen and ino are extracted even if the ha_fid is supposed to be
opaque ! The igen and ino number should have been extracted using FS
specific call (from fsys_vector).
But, now this is solved, fortunately :) since we used dm_fid_t.
(As dmapi.h is included in this file, maybe the XFS struct could be
replaced by their DMAPI equivalent ?)
Aurélien
|