xfs
[Top] [All Lists]

Re: BUG 799711 - LINUX XFS reports wrong permissions.

To: sgi.bugs.xfs@xxxxxxxxxxxxxxxxx, nb@xxxxxxx
Subject: Re: BUG 799711 - LINUX XFS reports wrong permissions.
From: "William L. Jones" <jones@xxxxxxxxxxxxxxxxxx>
Date: Wed, 23 Aug 2000 10:27:49 -0500
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <200008222305.QAA38808@info.engr.sgi.com>
Sender: owner-linux-xfs@xxxxxxxxxxx
open_by_handle can cause this, where you doning a xfsdump?

The problem in open_by_handle in xfs_ioctl.c. It is doing a linvfs_set_inode_ops
with out doing a linvfs_revalidate_core after, linvfs_set_inode_op clears
the perm bits in the mode field. The following patch
will fix the current oepn_by_handle:


*** xfs_ioctl.c.orig    Sat Aug 19 14:03:21 2000
--- xfs_ioctl.c Wed Aug 23 10:01:58 2000
***************
*** 481,486 ****
--- 481,492 ----
                 * Set xfs inode ops.
                 */
                linvfs_set_inode_ops(inode);
+
+               /*
+                * Fix the perm mode flags that linvfs_set_inode_ops bashes.
+                */
+               linvfs_revalidate_core(inode);
+
                d_add(dentry, inode);
        }
--------------------- end -------------------------------------------------


If this doesn't fix the problem then there may be some other place were linvfs_set_inode_ops gets called with out a linvfs_set_inode_ops call right after.

At 04:05 PM 8/22/00 -0700, cattelan@xxxxxxxxxxxx wrote:
View Incident: http://co-op.engr.sgi.com/BugWorks/code/bwxquery.cgi?search=Search&wlong=1&; view_type=Bug&wi=799711

Submitter : cattelan Submitter Domain : engr
Assigned Engineer : nb Assigned Domain : sgi.com
Assigned Group : xfs-linux Category : software
Customer Reported : F Priority : 3
Project : xfs-linux Status : open
Description :
nt8[5:33pm]-=>ls -l
total 121
drwxr-xrwx 16 cattelan sdivmisc 4096 Mar 6 18:37 ./
drwxrwxr-x 42 cattelan sdivmisc 4096 Apr 14 13:04 ../
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 BT_ESCM/
drwxr-xr-x 2 cattelan sdivmisc 4096 Aug 9 17:21 Chicane_FarFromTheMaddeni ngCrowds/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 GlobalUnderground_PaulOak enfold-NewYork_d1/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 GlobalUnderground_PaulOak enfold-NewYork_d2/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 JerryBonham_Interpretatio nsByJerryBonham/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 JerryBonham_SoundEscapes_ d1/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 JerryBonham_SoundEscapes_ d2/
drwxrwxr-x 2 cattelan sdivmisc 4096 Jul 28 1999 PaulOakenfold_Resident:Tw oYearsOfOakenfoldAtCream_d1/
d--------- 2 cattelan sdivmisc 4096 Jul 28 1999 PaulOakenfold_Resident:Tw oYearsOfOakenfoldAtCream_d2/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 PaulOakenfold_Tranceport/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 PaulVanDyk_45RPM/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 PaulVanDyk_SevenWays_d1/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 PaulVanDyk_SevenWays_d2/
drwxr-xr-x 13 cattelan sdivmisc 146 Oct 9 1998 cddb/


gibble[5:34pm]-=>ls -l
total 60
drwxr-xrwx 16 cattelan sdivmisc 4096 Mar 6 18:37 ./
drwxrwxr-x 42 cattelan sdivmisc 4096 Apr 14 13:04 ../
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 BT_ESCM/
drwxr-xr-x 2 cattelan sdivmisc 4096 Aug 9 17:21 Chicane_FarFromTheMaddeningCrowds/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 GlobalUnderground_PaulOakenfold-NewYork_d1/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 GlobalUnderground_PaulOakenfold-NewYork_d2/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 JerryBonham_InterpretationsByJerryBonham/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 JerryBonham_SoundEscapes_d1/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 JerryBonham_SoundEscapes_d2/
drwxrwxr-x 2 cattelan sdivmisc 4096 Jul 28 1999 PaulOakenfold_Resident:TwoYearsOfOakenfoldAtCream_d1/
drwxrwxr-x 2 cattelan sdivmisc 4096 Aug 22 17:32 PaulOakenfold_Resident:TwoYearsOfOakenfoldAtCream_d2/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 PaulOakenfold_Tranceport/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 PaulVanDyk_45RPM/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 PaulVanDyk_SevenWays_d1/
drwxr-xr-x 2 cattelan sdivmisc 4096 Feb 17 1999 PaulVanDyk_SevenWays_d2/
drwxr-xr-x 13 cattelan sdivmisc 146 Oct 9 1998 cddb/


<Prev in Thread] Current Thread [Next in Thread>