Re: error in xfs_logprint?

["Eric Sandeen" <sandeen@xxxxxxx>]

Hi Tang -

your patch looks quite reasonable to me, I'll let the Australians take a
look at it, since they "own" userspace.

I didn't get a core dump, though - which version of xfsprogs do you
have?

Thanks!

-Eric

Tang Lingbo wrote:
> 
> Hi,
> 
> There was a core dump in xfs_logprint when I did as follows:
> 
> 1)$ dd if=/dev/zero of=/tmp/xfs bs=1024 count=50000
> 2)$ mkfs.xfs /tmp/xfs
> 3)$ mount -t xfs -o loop /tmp/xfs /xfs
> 4)$ touch /xfs/test
> 5)$ for((i=0;i<1024;i++));do echo -n 1 >> /tmp/dummy;done
> 6)$ value=`cat /tmp/dummy`;attr -s test -V $value /xfs/test
> 7)$ xfs_logprint /tmp/xfs
> 
> output:
> 
> ...
> xlog_print_trans_inode: illegal inode type
> 
> And I think the patch will be as follows:

-- 
Eric Sandeen      XFS for Linux     http://oss.sgi.com/projects/xfs
sandeen@xxxxxxx   SGI, Inc.