Samba panic with ACLs

[Hasch@xxxxxxxxxxx (Juergen Hasch)]

There is a bug in acl.c/acl_get_qualifier. The Posix draft states
the object returned by acl_get_qualifier should be cleared using
acl_free. This crashes Samba because we only return a pointer from
inside an existing object.
The patch below fixes this, I somehow missed this before...

--- acl.orig    Fri Jun  8 22:53:48 2001
+++ acl.c       Tue Jun 19 19:43:37 2001
@@ -996,6 +996,8 @@
 void *
 acl_get_qualifier (acl_entry_t entry_d)
 {
+       uid_t *retval;
+
        if(entry_d == NULL){
                setoserror(EINVAL);
                return NULL;
        }
        
-       return &entry_d->ae_id;
+       retval = malloc(sizeof(uid_t));
+       if (!retval)
+               return NULL;
+       *retval = entry_d->ae_id;
+       return retval;
 }
 
 int