Steve Lord wrote:
> > To reiterate, the problems I'm having are:
> >
> > First: If I set an ACL, and immediatly attempt to excersize it
> > (notablly turning off owner execute), it fails. Inserting an acl_get(2)
> > or a stat(2) between the acl_set(2) and execl(2) attempt, corrects the
> > problem.
> >
> > Second: sometimes after running the test suite, the executable becomes
> > unable to execute any more, failing with 'Text file busy'. The XFS
> > partition can't be unmounted after that point. Sorry, I've not been
> > able to narrow this one any further.
>
> This patch does not apply very well - you appear to be sending diffs to
> files which do not currently appear in the xfs tree, e.g. the contents of
> cmd/xfs/acl. It is also a patch against test8 rather than the current test10.
>
> If possible could you please move your code base up to the latest development
> tree, and redo the patch using diff -Nuar between an unmodified tree and your
> modified tree.
Okay, here's a patch which should be much happier! It's against
test10, and seems to work on my system.
I've corrected the problems Steve mentioned, and ran diff properly (I
think). Please try it, and let me know what you think.
I noticed that the attr_get, set, remove, et. al. have been changed to
be just one system call instead of five (or so). Should I also emulate
that and create only one system call for ACLs?
--
"Men occasionally stumble over the truth, but most of them pick
themselves up and hurry off as if nothing had happened."
-- Winston Churchill
Danny
acl.patch.bz2
Description: Binary data
|