Steve Lord wrote:
>
> > >
> > > I am backing out this change, it breaks doio, and probably anything else
> > > which fills holes in files. I think we had a similar test condition in
> > > this code path before, and it was removed to fix corruption. There has
> > > got to be another variant of this which we can use.
> > >
> > > Steve
> > >
> >
> > OK, now I am puzzled, I still got corruption after I backed out the mod,
> > I removed the old doio output file and the corruption went away on
> > subsequent
> > runs and I have not been able to reproduce it with or without the mod again.
> I
> > will run some more tests and probably be putting the mod back in again
> > shortl
> y.
> >
> > Sorry for the confusion.
> >
> > Steve
> >
>
> Looks like the corruption is once again coming out of the clustering write
> code in pagebuf, I would recommend not using the kiocluster mount option
> at the moment. I am doing a glibc build with Ananth's change back in again
> and put it back into the tree if the build works OK.
>
Yikes! Sorry if my change caused this problem.
But I ran rpmbuild, kernel build and doio (1,2
threads) before checking-in the change ...
--
--------------------------------------------------------------------------
Rajagopal Ananthanarayanan ("ananth")
Member Technical Staff, SGI.
--------------------------------------------------------------------------
|