xfs
[Top] [All Lists]

Re: TAKE - remove use of -funsigned-char from xfs

To: Eric Sandeen <sandeen@xxxxxxx>
Subject: Re: TAKE - remove use of -funsigned-char from xfs
From: Keith Owens <kaos@xxxxxxx>
Date: Thu, 24 Jan 2002 16:34:03 +1100
Cc: Stephen Lord <lord@xxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: Your message of "Wed, 23 Jan 2002 21:32:20 MDT." <Pine.LNX.4.33.0201232126580.21727-100000@chuckle.americas.sgi.com>
Sender: owner-linux-xfs@xxxxxxxxxxx
On Wed, 23 Jan 2002 21:32:20 -0600 (CST), 
Eric Sandeen <sandeen@xxxxxxx> wrote:
>Keith, I'd like your input on this, since you're the guru.  :)
>
>I took care of your(?) comment in the makefiles:
>
># This needs -I. because everything does #include <xfs.h> instead of "xfs.h".
># The code is wrong, local files should be included using "xfs.h", not <xfs.h>
># but I am not going to change every file at the moment.
>
>and changed all the xfs #includes to local includes, but for some of the
>files in fs/xfs/linux, we need to include files from fs/xfs.  It looks a bit
>ugly to do:
>
>#include "../xfs.h"
>
>Is there a better way?

In the source, always do #include "xfs.h".  Then you can rearrange
directories, move source between directories etc. without changing the
code.  In the Makefile, use EXTRA_CFLAGS += -I $(TOPDIR)/fs/xfs.


<Prev in Thread] Current Thread [Next in Thread>