xfs
[Top] [All Lists]

[PATCH] mm: remove unnecessary rcu_lock/unlock around radix_tree_tagged

To: xfs@xxxxxxxxxxx, david@xxxxxxxxxxxxx, hch@xxxxxxxxxxxxx
Subject: [PATCH] mm: remove unnecessary rcu_lock/unlock around radix_tree_tagged lockless function. The function queue_delayed_work is already protected with interrupts disabled, hence no need to add rcu_lock/unlock.
From: Sudip Midya <midya.sudip@xxxxxxxxx>
Date: Mon, 26 Sep 2016 00:50:06 +0530
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=0JfidArroiOBDXMqcL0IwhGUoHd2VfyEqIgb26g27G4=; b=rPenfyWv/ZWh3PtNF7AW8bWUtUDSSMO7WXx4SbuNJTTdvrxQwT8J67/5KPb3ZpX9Ck y1Bj7jRXjLB3EkeQ7tc1N41YguSfWDQlx6hs/m6qdsEkSXaTLCZnH8GmrK6sEWQ60vlG Dh8gkonWyPWPecdvdJZ5u0W8WGiwbsBgShIYrmUoK63vDXciQ74PWj1a8MJc+l6gc4w/ Hn2q2U0AhCgiu2/URJgHcWC4dvRk+tS+3STmFdb2YvBi6Cw/DsMX7qGFZamtOgAsmuxZ OM0pwcDV52ZqK7uPHZvc4tG/cdNPiHQfwc3jDtLfoqOAf76RB0LBCfeXjW6Cma9c8Q9+ ghtw==
User-agent: Mutt/1.5.21 (2010-09-15)
Signed-off-by: Sudip Midya <midya.sudip@xxxxxxxxx>
---
 fs/xfs/xfs_icache.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index fb39a66..887c868 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -153,12 +153,10 @@ xfs_reclaim_work_queue(
        struct xfs_mount        *mp)
 {
 
-       rcu_read_lock();
        if (radix_tree_tagged(&mp->m_perag_tree, XFS_ICI_RECLAIM_TAG)) {
                queue_delayed_work(mp->m_reclaim_workqueue, &mp->m_reclaim_work,
                        msecs_to_jiffies(xfs_syncd_centisecs / 6 * 10));
        }
-       rcu_read_unlock();
 }
 
 /*
-- 
1.9.1


<Prev in Thread] Current Thread [Next in Thread>