xfs
[Top] [All Lists]

Re: [PATCH 58/71] xfs: garbage collect old cowextsz reservations

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 58/71] xfs: garbage collect old cowextsz reservations
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 24 Sep 2016 12:42:34 -0700
Cc: david@xxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <147216829394.867.16281333542262043955.stgit@xxxxxxxxxxxxxxxx>
References: <147216791538.867.12413509832420924168.stgit@xxxxxxxxxxxxxxxx> <147216829394.867.16281333542262043955.stgit@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.6.1 (2016-04-27)
On Thu, Aug 25, 2016 at 04:38:14PM -0700, Darrick J. Wong wrote:
> Trim CoW reservations made on behalf of a cowextsz hint if they get too
> old or we run low on quota, so long as we don't have dirty data awaiting
> writeback or directio operations in progress.

FYI, at least in your latest tree we only ever seem to set
xfs_inode_set_cowblocks_tag in xfs_swap_extents, so this effectively
isn't used during normal fs usage.

Also any reason we can't use the same infrastructure as our normal
speculative preallocation here?

<Prev in Thread] Current Thread [Next in Thread>