[PATCH] vfs: fix return type of ioctl_file_dedupe

To:	torvalds@xxxxxxxxxxxxxxxxxxxx
Subject:	[PATCH] vfs: fix return type of ioctl_file_dedupe_range
From:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date:	Wed, 14 Sep 2016 20:20:00 -0700
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, david@xxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
User-agent:	Mutt/1.5.24 (2015-08-30)

All the VFS functions in the dedupe ioctl path return int status, so
the ioctl handler ought to as well.

Found by Coverity, CID 1350952.

Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
---
 fs/ioctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ioctl.c b/fs/ioctl.c
index 0f56deb..26aba09 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -568,7 +568,7 @@ static int ioctl_fsthaw(struct file *filp)
        return thaw_super(sb);
 }
 
-static long ioctl_file_dedupe_range(struct file *file, void __user *arg)
+static int ioctl_file_dedupe_range(struct file *file, void __user *arg)
 {
        struct file_dedupe_range __user *argp = arg;
        struct file_dedupe_range *same = NULL;

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] vfs: fix return type of ioctl_file_dedupe_range, Darrick J. Wong <=

Previous by Date:	Re: [PATCH V4] xfs: Document error handlers behavior, Eric Sandeen
Next by Date:	[PATCH] vfs: cap dedupe request structure size at PAGE_SIZE, Darrick J. Wong
Previous by Thread:	[PATCH 0/3] xfsprogs: xfs_quota foreign fs path handling modifications, Bill O'Donnell
Next by Thread:	[PATCH] vfs: cap dedupe request structure size at PAGE_SIZE, Darrick J. Wong
Indexes:	[Date] [Thread] [Top] [All Lists]

[PATCH] vfs: fix return type of ioctl_file_dedupe_range