xfs
[Top] [All Lists]

Re: [PATCH, RFC] xfs: remove i_iolock and use i_rwsem in the VFS inode i

To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Subject: Re: [PATCH, RFC] xfs: remove i_iolock and use i_rwsem in the VFS inode instead
From: Ingo Molnar <mingo@xxxxxxxxxx>
Date: Thu, 8 Sep 2016 08:06:55 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uTIGfLhSe0TJruP9KcPafVHsHBTA5vP8t6f7cK9yqDg=; b=WDlDRl1GPM+gmDnBZCLixoVrvbW8o9p6t/MVy1+ttTFtC+Q8KOuAeIZUMo3XXWD7nJ BW+Z6aOdtbyqbHhflxDjWZsRYx1Uqh4atRPrvQt9PUKsZaPgUUkPTyRy/BQc9fUgTmh/ KVXE7WY/n0LqEdFK/kdNwYa1L7UAXuCfwfO+4S+6IBX1SzB3QImRSNiTJmQdz6IKbZwe DqwcbGk6jJjM8LyV4ZDFJAIKU+qxwdBqm8k8abMDGQohDCwM4/kyxRt+fRgsyJjfxKDb RRI0sD7u2nIjM26bHylcqHAR50dKqIM9pRGjnhHxj7ySAqblSa4GTFrkHux8JtkfyJrG l/ng==
In-reply-to: <20160907074312.GQ10153@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1470935423-12329-1-git-send-email-hch@xxxxxx> <20160811215444.GY30192@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20160818173707.GA1240@xxxxxx> <20160819132736.GH10121@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20160820063723.GA7013@xxxxxx> <20160822083455.GH10153@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20160905151244.GA16726@xxxxxx> <20160907074312.GQ10153@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: Ingo Molnar <mingo.kernel.org@xxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Mon, Sep 05, 2016 at 05:12:44PM +0200, Christoph Hellwig wrote:
> > Peter, this is the fixed up patch.  Can you write a proper changelog
> > and add your signoff?
> 
> Yes, sorry for the delay.
> 
> Did you get the workqueue thing sorted, where you rely on another task
> holding the lock for you?
> 
> I simplified the implementation a little, since I noticed pushing the
> @read argument all the way down to match_held_lock() didn't really make
> all that much sense and caused a lot of churn.
> 
> I also added CONFIG_LOCKDEP=n stubs for the new lockdep_assert_held*()
> macros (which you don't use :-).
> 
> Feel free to push this through the XFS tree where you add its first use.

I can also create a separate one-commit tree for it which you can pull into the 
XFS tree. This way there won't be conflicts between the XFS tree and the 
locking 
tree.

Thanks,

        Ingo

<Prev in Thread] Current Thread [Next in Thread>