| To: | Eryu Guan <eguan@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs/279: filter scsi debug device correctly |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 8 Sep 2016 08:47:47 +1000 |
| Cc: | fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1473053427-15498-1-git-send-email-eguan@xxxxxxxxxx> |
| References: | <1473053427-15498-1-git-send-email-eguan@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Sep 05, 2016 at 01:30:27PM +0800, Eryu Guan wrote: > This test assumes scsi debug device is "/dev/sd." when doing the > filter, but that isn't always true, I've seen failure like > > -mkfs with opts: DEVICE > +mkfs with opts: DEVICEl Yeah, I can see how that would occur when you have enough scsi devices to go to multiple device characters (e.g. /dev/sdal). > So use $SCSI_DEBUG_DEV to match the correct scsi debug device name. > > Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH, RFC] xfs: remove i_iolock and use i_rwsem in the VFS inode instead, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 2/6] libxfs/linux.c: Replace use of ustat by stat, Dave Chinner |
| Previous by Thread: | [PATCH] xfs/279: filter scsi debug device correctly, Eryu Guan |
| Next by Thread: | XFS reflink and development tip git trees updated, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |