xfs
[Top] [All Lists]

Re: [PATCH 07/71] xfs: define tracepoints for refcount btree activities

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 07/71] xfs: define tracepoints for refcount btree activities
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 6 Sep 2016 07:54:46 -0700
Cc: david@xxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <147216796400.867.3093949883691867882.stgit@xxxxxxxxxxxxxxxx>
References: <147216791538.867.12413509832420924168.stgit@xxxxxxxxxxxxxxxx> <147216796400.867.3093949883691867882.stgit@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.6.1 (2016-04-27)
> +#ifndef XFS_REFCOUNT_IREC_PLACEHOLDER
> +#define XFS_REFCOUNT_IREC_PLACEHOLDER
> +/* Placeholder definition to avoid breaking bisectability. */
> +struct xfs_refcount_irec {
> +     xfs_agblock_t   rc_startblock;  /* starting block number */
> +     xfs_extlen_t    rc_blockcount;  /* count of free blocks */
> +     xfs_nlink_t     rc_refcount;    /* number of inodes linked here */
> +};
> +#endif

I didn't really understand the point earlier either - why can't
you just merge the patch adding the tracepoints into that defining
the structures and calling the tracepoints?  That would avoid that
whole exercise.

<Prev in Thread] Current Thread [Next in Thread>