| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 02/71] xfs: create a standard btree size calculator code |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 5 Sep 2016 08:05:00 -0700 |
| Cc: | david@xxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <147216792896.867.711816517859232858.stgit@xxxxxxxxxxxxxxxx> |
| References: | <147216791538.867.12413509832420924168.stgit@xxxxxxxxxxxxxxxx> <147216792896.867.711816517859232858.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.6.1 (2016-04-27) |
On Thu, Aug 25, 2016 at 04:32:09PM -0700, Darrick J. Wong wrote: > Create a helper to generate AG btree height calculator functions. > This will be used (much) later when we get to the refcount btree. > > v2: Use a helper function instead of a macro. > v3: We can (theoretically) store more than 2^32 records in a btree, so > widen the fields to accept that. > v4: Don't modify xfs_bmap_worst_indlen; the purpose of /that/ function > is to estimate the worst-case number of blocks needed for a bmbt > expansion, not to calculate the space required to store nr records. > v5: More minor tweaks to the loop control; move down to reflink patches. This should move down below the "---" line. Otherwise the patch looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 01/71] xfs: remove xfs_btree_bigkey, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 03/71] xfs: count the blocks in a btree, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 01/71] xfs: remove xfs_btree_bigkey, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 03/71] xfs: count the blocks in a btree, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |