| To: | Christoph Hellwig <hch@xxxxxx> |
|---|---|
| Subject: | Re: [PATCH, RFC] xfs: remove i_iolock and use i_rwsem in the VFS inode instead |
| From: | Peter Zijlstra <peterz@xxxxxxxxxxxxx> |
| Date: | Fri, 19 Aug 2016 15:27:36 +0200 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160818173707.GA1240@xxxxxx> |
| References: | <1470935423-12329-1-git-send-email-hch@xxxxxx> <20160811215444.GY30192@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20160818173707.GA1240@xxxxxx> |
| User-agent: | Mutt/1.5.23.1 (2014-03-12) |
On Thu, Aug 18, 2016 at 07:37:07PM +0200, Christoph Hellwig wrote: > On Thu, Aug 11, 2016 at 11:54:44PM +0200, Peter Zijlstra wrote: > > Sure, find below. Not been near a compiler. > > It has now. Below are the additions I need, and things seem to be > passing fine with that. > > Note that to fit the existing XFS lock asserts I'm using > _lockdep_is_held directly instead of lockdep_assert_held_exclusive. > All the exports are there, but I'm just trying to make sure you're > not going to shout at me for that later :) Hurm, if you're going to directly use that maybe we should pick a better name ;-) Also, be sure to check the debug_locks variable, if that's cleared the result of _lockdep_is_held() isn't reliable -- we stop tracking lock state when there's an error. Thanks! |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] PING... mkfs.xfs: fix static-lib build, Dave Chinner |
|---|---|
| Next by Date: | Votre compte PayPal est actuellement restreint., service |
| Previous by Thread: | Re: [PATCH, RFC] xfs: remove i_iolock and use i_rwsem in the VFS inode instead, Christoph Hellwig |
| Next by Thread: | Re: [PATCH, RFC] xfs: remove i_iolock and use i_rwsem in the VFS inode instead, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |