xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok()

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 9 Aug 2016 02:35:31 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, xfs@xxxxxxxxxxx, "Yan, Zheng" <zyan@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Ilya Dryomov <idryomov@xxxxxxxxx>, ceph-devel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160809093246.GB5107@xxxxxxxxxxxxxx>
References: <1470223689-17783-1-git-send-email-jack@xxxxxxx> <1470223689-17783-2-git-send-email-jack@xxxxxxx> <20160809082756.GA11657@xxxxxxxxxxxxx> <20160809093246.GB5107@xxxxxxxxxxxxxx>
User-agent: Mutt/1.6.1 (2016-04-27)
On Tue, Aug 09, 2016 at 11:32:46AM +0200, Jan Kara wrote:
> So do you suggest xfs_iop_change_ok and xfs_iop_setattr_nonsize? I don't
> really care, I just remember Dave had some ideas how names should be
> consistent and this naming was his idea...

Nah, just skip the prefix entirely, and maybe also already adopt to
the new setattr_prepare naming.  But if Dave already had an opinions
let's just keep it as-is and sort the naming out later.

<Prev in Thread] Current Thread [Next in Thread>