xfs
[Top] [All Lists]

Re: [PATCH] xfs: kill __uint*_t and __int*_t

To: Felix Janda <felix.janda@xxxxxxxxx>
Subject: Re: [PATCH] xfs: kill __uint*_t and __int*_t
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 9 Aug 2016 01:33:32 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160807173835.GA20839@nyan>
References: <20160807173835.GA20839@nyan>
User-agent: Mutt/1.6.1 (2016-04-27)
On Sun, Aug 07, 2016 at 07:38:35PM +0200, Felix Janda wrote:
> Replace them by the more widely used uint*_t and int*_t.
> 
> Signed-off-by: Felix Janda <felix.janda@xxxxxxxxx>
> ---
> This patch is essentially a global
> 'sed -i "s/__\(u*\)int\([0-9]*\)_t/\1int\2_t/"'. The only other changes
> are whitespace changes and removing the now unecessary type definitions.
> 
> Running 'sed "s/^.//"' on the patch might be useful for checking that
> I didn't mess up the indentation.

If everyone is fine using (u)int*_t over s*/u* this looks good.  I'd
have a slight preference for s*/u* as in the rest of the kernel, but
either way getting rid of our crazy __ types is a good thing.

<Prev in Thread] Current Thread [Next in Thread>