Re: [PATCH 1/2] iomap: fiemap should honor the FIEMAP_FLAG

xfs

Re: [PATCH 1/2] iomap: fiemap should honor the FIEMAP_FLAG_SYNC flag

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/2] iomap: fiemap should honor the FIEMAP_FLAG_SYNC flag
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 9 Aug 2016 00:28:36 -0700
Cc:	xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1470637351-27933-2-git-send-email-david@xxxxxxxxxxxxx>
References:	<1470637351-27933-1-git-send-email-david@xxxxxxxxxxxxx> <1470637351-27933-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.6.1 (2016-04-27)

On Mon, Aug 08, 2016 at 04:22:30PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The flag is checked as supported, but then we do an unconditional
> sync of the file, regardless of whether the flag is set or not. Make
> the sync conditional on having the FIEMAP_FLAG_SYNC flag set.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2] iomap: fixes for fiemap interface, Dave Chinner [PATCH 1/2] iomap: fiemap should honor the FIEMAP_FLAG_SYNC flag, Dave Chinner Re: [PATCH 1/2] iomap: fiemap should honor the FIEMAP_FLAG_SYNC flag, Christoph Hellwig <= [PATCH 2/2] iomap: add fiemap support for attribute mappings, Dave Chinner Re: [PATCH 2/2] iomap: add fiemap support for attribute mappings, Christoph Hellwig

Previous by Date:	Re: [PATCH 13/17] xfs: test swapext with reflink, Dave Chinner
Next by Date:	Re: [PATCH 2/2] iomap: add fiemap support for attribute mappings, Christoph Hellwig
Previous by Thread:	[PATCH 1/2] iomap: fiemap should honor the FIEMAP_FLAG_SYNC flag, Dave Chinner
Next by Thread:	[PATCH 2/2] iomap: add fiemap support for attribute mappings, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]