| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 13/17] xfs: test swapext with reflink |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 9 Aug 2016 16:29:43 +1000 |
| Cc: | Eryu Guan <eguan@xxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160808174132.GC11291@xxxxxxxxxxxxxxxx> |
| References: | <146914477514.11762.3144320628851923350.stgit@xxxxxxxxxxxxxxxx> <146914485888.11762.1688573359701830686.stgit@xxxxxxxxxxxxxxxx> <20160808081359.GB27776@xxxxxxxxxxxxxxxxxxxxxxxx> <20160808174132.GC11291@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Aug 08, 2016 at 10:41:32AM -0700, Darrick J. Wong wrote: > On Mon, Aug 08, 2016 at 04:13:59PM +0800, Eryu Guan wrote: > > On Thu, Jul 21, 2016 at 04:47:38PM -0700, Darrick J. Wong wrote: > > > Add a few tests to stress the new swapext code for reflink and rmap. > > > +_reflink_range "$testdir/file1" 0 "$testdir/file2" 0 $bytes >> > > > "$seqres.full" > > > + > > > +echo "Defrag the big file" > > > +old_nextents=$(xfs_io -c 'stat -v' $testdir/file1 | grep 'nextents' | > > > cut -d ' ' -f 3) > > > > There's a "_count_extents" helper, does that work for this case? > > It can, though stat -v reports GETFSXATTR results, which should be faster than > _count_extents because the latter FIEMAPs the entire file and counts lines. > Seeing as XFS records the extent count in the inode, we might as well use it. perhaps put a special xfs case in _count_extents() that does this rather than FIEMAP? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Subtle races between DAX mmap fault and write path, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 1/2] iomap: fiemap should honor the FIEMAP_FLAG_SYNC flag, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 13/17] xfs: test swapext with reflink, Darrick J. Wong |
| Next by Thread: | Re: [PATCH 13/17] xfs: test swapext with reflink, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |