xfs
[Top] [All Lists]

Re: [PATCH v7 00/47] xfs: add reverse mapping support

To: Artem Bityutskiy <dedekind1@xxxxxxxxx>
Subject: Re: [PATCH v7 00/47] xfs: add reverse mapping support
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 5 Aug 2016 20:49:50 +1000
Cc: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, bfoster@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1470380474.2311.71.camel@xxxxxxxxx>
References: <146907695530.25461.3225785294902719773.stgit@xxxxxxxxxxxxxxxx> <20160803194536.GJ5316@xxxxxxxxxxxxx> <20160803205520.GQ8590@xxxxxxxxxxxxxxxx> <20160804005843.GJ8593@xxxxxxxxxxxxxxxx> <20160804021852.GK5316@xxxxxxxxxxxxx> <20160804154845.GV8590@xxxxxxxxxxxxxxxx> <20160804235015.GC16044@dastard> <1470380474.2311.71.camel@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Aug 05, 2016 at 10:01:14AM +0300, Artem Bityutskiy wrote:
> On Fri, 2016-08-05 at 09:50 +1000, Dave Chinner wrote:
> > I'd much prefer that fiemap gives exact information about shared
> > extents. FIEMAP is a diagnostic tool and as such we need it to
> > accurately reflect the exact extent map of the inode being queried
> > so we aren't mislead about the layout of the file during trouble
> > shooting.
> 
> Hi Dave, you are right, and here is a side note:  we were using FIEMAP
> for optimizing image deployment in production, so it is a diagnostic
> tool and more.

Yay, data corruption ahoy!

Hasn't /anyone/ listened to the repeated statements from fs
developers that FIEMAP is not a safe method of optimising data
copying?

-Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>