xfs
[Top] [All Lists]

Re: [PATCH] generic/095: update warning whitelist

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] generic/095: update warning whitelist
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 3 Aug 2016 09:23:05 +1000
Cc: fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1470042176-31447-1-git-send-email-hch@xxxxxx>
References: <1470042176-31447-1-git-send-email-hch@xxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Aug 01, 2016 at 11:02:56AM +0200, Christoph Hellwig wrote:
> The recent direct I/O path refactor changed the function name in the
> racing read case.  Update the test case to handle the new name in
> addition to the old one.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  tests/generic/095 | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/generic/095 b/tests/generic/095
> index c656ef1..4754992 100755
> --- a/tests/generic/095
> +++ b/tests/generic/095
> @@ -125,9 +125,11 @@ $FIO_PROG $fio_config >>$seqres.full 2>&1
>  filter_xfs_dmesg()
>  {
>       local warn1="WARNING:.*fs/xfs/xfs_file\.c:.*xfs_file_dio_aio_write.*"
> -     local warn2="WARNING:.*fs/xfs/xfs_file\.c:.*xfs_file_read_iter.*"
> +     local warn2="WARNING:.*fs/xfs/xfs_file\.c:.*xfs_file_dio_aio_read.*"
> +     local warn3="WARNING:.*fs/xfs/xfs_file\.c:.*xfs_file_read_iter.*"
>       sed -e "s#$warn1#Intentional warnings in xfs_file_dio_aio_write#" \
> -         -e "s#$warn2#Intentional warnings in xfs_file_read_iter#"
> +         -e "s#$warn2#Intentional warnings in xfs_file_dio_aio_read#" \
> +         -e "s#$warn3#Intentional warnings in xfs_file_read_iter#"
>  }

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>