xfs
[Top] [All Lists]

Re: [PATCH] xfs: in _attrlist_by_handle, copy the cursor back to userspa

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: in _attrlist_by_handle, copy the cursor back to userspace
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Tue, 2 Aug 2016 08:40:35 -0700
Cc: david@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160802122517.GD31492@xxxxxxxxxxxxx>
References: <20160802035651.GB8593@xxxxxxxxxxxxxxxx> <20160802122517.GD31492@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Tue, Aug 02, 2016 at 05:25:17AM -0700, Christoph Hellwig wrote:
> On Mon, Aug 01, 2016 at 08:56:51PM -0700, Darrick J. Wong wrote:
> > When we're iterating inode xattrs by handle, we have to copy the
> > cursor back to userspace so that a subsequent invocation actually
> > retrieves subsequent contents.
> 
> Testcase?

Found it while continuing development of xfs_scrub.  I'll send along the
xfstest patch when I've finished polishing it.  (It was harder than usual since
xfs_io doesn't /use/ the attr-by-handle interface... nothing does.)

--D

<Prev in Thread] Current Thread [Next in Thread>