| To: | Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] vfs: fix return type of ioctl_file_dedupe_range |
| From: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
| Date: | Mon, 1 Aug 2016 10:13:39 -0700 |
| Cc: | xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
All the VFS functions in the dedupe ioctl path return int status, so
the ioctl handler ought to as well.
Found by Coverity, CID 1350952.
Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
---
fs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ioctl.c b/fs/ioctl.c
index 116a333..db3d033 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -568,7 +568,7 @@ static int ioctl_fsthaw(struct file *filp)
return thaw_super(sb);
}
-static long ioctl_file_dedupe_range(struct file *file, void __user *arg)
+static int ioctl_file_dedupe_range(struct file *file, void __user *arg)
{
struct file_dedupe_range __user *argp = arg;
struct file_dedupe_range *same = NULL;
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 06/17] xfs: run xfs_repair at the end of each test, Darrick J. Wong |
|---|---|
| Next by Date: | Re: [PATCH 07/47] xfs: add function pointers for get/update keys to the btree, Darrick J. Wong |
| Previous by Thread: | Re: [PATCH v2 07/47] xfs: add function pointers for get/update keys to the btree, Brian Foster |
| Next by Thread: | Re: [PATCH] vfs: fix return type of ioctl_file_dedupe_range, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |