| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 07/47] xfs: add function pointers for get/update keys to the btree |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 31 Jul 2016 23:39:02 -0700 |
| Cc: | david@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, bfoster@xxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <146907700604.25461.2181974283557088355.stgit@xxxxxxxxxxxxxxxx> |
| References: | <146907695530.25461.3225785294902719773.stgit@xxxxxxxxxxxxxxxx> <146907700604.25461.2181974283557088355.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.6.1 (2016-04-27) |
On Wed, Jul 20, 2016 at 09:56:46PM -0700, Darrick J. Wong wrote: > Add some function pointers to bc_ops to get the btree keys for > leaf and node blocks, and to update parent keys of a block. > Convert the _btree_updkey calls to use our new pointer, and > modify the tree shape changing code to call the appropriate > get_*_keys pointer instead of _btree_copy_keys because the > overlapping btree has to calculate high key values. I don't really like to add ops for something that isn't really per-btree type. Can you just add an overlapping flag and act based on that? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 06/47] xfs: during btree split, save new block key & ptr for future insertion, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 08/47] xfs: support btrees with overlapping intervals for keys, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 06/47] xfs: during btree split, save new block key & ptr for future insertion, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 07/47] xfs: add function pointers for get/update keys to the btree, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |