xfs
[Top] [All Lists]

Re: [PATCH xfsprogs 2/2] linux.h: Define xfs_off_t as int64_t

To: Felix Janda <felix.janda@xxxxxxxxx>
Subject: Re: [PATCH xfsprogs 2/2] linux.h: Define xfs_off_t as int64_t
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 31 Jul 2016 23:24:49 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160730133737.GB5895@nyan>
References: <20160730133737.GB5895@nyan>
User-agent: Mutt/1.6.1 (2016-04-27)
On Sat, Jul 30, 2016 at 03:37:37PM +0200, Felix Janda wrote:
> int64_t is guaranteed to have the correct size and signedness and is
> always avaible because linux.h has a <inttypes.h> include.
> 
> Fixes compilation error "unkown type name 'off64_t'" on linux when the
> public header <xfs.h> is included without _LARGEFILE64_SOURCE or
> _GNU_SOURCE defined. This bug was introduced in commit
> cb898f157f8410a03cf5f3400baa1df9e5eecd33.

I would much prefer to just define _LARGEFILE64_SOURCE in linux.h..

<Prev in Thread] Current Thread [Next in Thread>