| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/47] xfs: set *stat=1 after iroot realloc |
| From: | Brian Foster <bfoster@xxxxxxxxxx> |
| Date: | Tue, 26 Jul 2016 12:36:12 -0400 |
| Cc: | david@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <146907699326.25461.8018421055879226973.stgit@xxxxxxxxxxxxxxxx> |
| References: | <146907695530.25461.3225785294902719773.stgit@xxxxxxxxxxxxxxxx> <146907699326.25461.8018421055879226973.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.6.2 (2016-07-01) |
On Wed, Jul 20, 2016 at 09:56:33PM -0700, Darrick J. Wong wrote:
> If we make the inode root block of a btree unfull by expanding the
> root, we must set *stat to 1 to signal success, rather than leaving
> it uninitialized.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
> fs/xfs/libxfs/xfs_btree.c | 1 +
> 1 file changed, 1 insertion(+)
>
>
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index 07eeb0b..f5ff95a 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -2871,6 +2871,7 @@ xfs_btree_make_block_unfull(
> if (numrecs < cur->bc_ops->get_dmaxrecs(cur, level)) {
> /* A root block that can be made bigger. */
> xfs_iroot_realloc(ip, 1, cur->bc_private.b.whichfork);
> + *stat = 1;
> } else {
> /* A root block that needs replacing */
> int logflags = 0;
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
|
| Previous by Date: | Re: [PATCH 04/47] xfs: fix locking of the rt bitmap/summary inodes, Brian Foster |
|---|---|
| Next by Date: | Re: [PATCH 06/47] xfs: during btree split, save new block key & ptr for future insertion, Brian Foster |
| Previous by Thread: | [PATCH 05/47] xfs: set *stat=1 after iroot realloc, Darrick J. Wong |
| Next by Thread: | [PATCH 06/47] xfs: during btree split, save new block key & ptr for future insertion, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |