xfs
[Top] [All Lists]

Re: [PATCH 047/119] xfs: disable XFS_IOC_SWAPEXT when rmap btree is enab

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 047/119] xfs: disable XFS_IOC_SWAPEXT when rmap btree is enabled
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 18 Jul 2016 09:34:28 -0400
Cc: david@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <146612657322.12839.9067889093004523073.stgit@xxxxxxxxxxxxxxxx>
References: <146612627129.12839.3827886950949809165.stgit@xxxxxxxxxxxxxxxx> <146612657322.12839.9067889093004523073.stgit@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.6.1 (2016-04-27)
On Thu, Jun 16, 2016 at 06:22:53PM -0700, Darrick J. Wong wrote:
> Swapping extents between two inodes requires the owner to be updated
> in the rmap tree for all the extents that are swapped. This code
> does not yet exist, so switch off the XFS_IOC_SWAPEXT ioctl until
> support has been implemented. This will need to be done before the
> rmap btree code can have the experimental tag removed.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> [darrick.wong@xxxxxxxxxx: fix extent swapping when rmap enabled]
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

>  fs/xfs/xfs_bmap_util.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> 
> diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
> index 450fd49..8666873 100644
> --- a/fs/xfs/xfs_bmap_util.c
> +++ b/fs/xfs/xfs_bmap_util.c
> @@ -1618,6 +1618,10 @@ xfs_swap_extents(
>       __uint64_t      tmp;
>       int             lock_flags;
>  
> +     /* XXX: we can't do this with rmap, will fix later */
> +     if (xfs_sb_version_hasrmapbt(&mp->m_sb))
> +             return -EOPNOTSUPP;
> +
>       tempifp = kmem_alloc(sizeof(xfs_ifork_t), KM_MAYFAIL);
>       if (!tempifp) {
>               error = -ENOMEM;
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>