xfs
[Top] [All Lists]

Re: [PATCH] nfsd: allow SCSI layout support without Block layout

To: Benjamin Coddington <bcodding@xxxxxxxxxx>
Subject: Re: [PATCH] nfsd: allow SCSI layout support without Block layout
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 6 Jul 2016 19:19:53 +1000
Cc: xfs@xxxxxxxxxxx, bfields@xxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <74871b1ce0d09b21fb67c1b2176695cc1c19169e.1467624319.git.bcodding@xxxxxxxxxx>
References: <74871b1ce0d09b21fb67c1b2176695cc1c19169e.1467624319.git.bcodding@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jul 05, 2016 at 09:48:47PM -0400, Benjamin Coddington wrote:
> We shouldn't have to configure both NFSD_BLOCKLAYOUT and NFSD_SCSILAYOUT if
> all we want are SCSI layouts on the server, so define the xfs export
> operations for either configuration.
> 
> Signed-off-by: Benjamin Coddington <bcodding@xxxxxxxxxx>

I don't really like exploding config option dependencies into
subsystems that aren't actually related to the config options.
It's confusing enough laready that we've got XFS code dependent on
PNFSD config options without adding more to it. Instead, I'd
suggest this should be resolved in the kconfig files. i.e. make
CONFIG_NFSD_SCSILAYOUT=y select CONFIG_NFSD_BLOCKLAYOUT to resolve
the config dependency at config time.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>