xfs
[Top] [All Lists]

Re: [PATCH 008/145] libxfs: add more list operations

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 008/145] libxfs: add more list operations
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Thu, 23 Jun 2016 17:46:38 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160624004022.GB12670@dastard>
References: <146612704434.16048.12932915166928562654.stgit@xxxxxxxxxxxxxxxx> <146612709549.16048.6522744362673808871.stgit@xxxxxxxxxxxxxxxx> <20160624004022.GB12670@dastard>
User-agent: Mutt/1.5.24 (2015-08-30)
On Fri, Jun 24, 2016 at 10:40:22AM +1000, Dave Chinner wrote:
> On Thu, Jun 16, 2016 at 06:31:35PM -0700, Darrick J. Wong wrote:
> > Add some list operations that the deferred rmap code requires.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> This has all come from the linux kernel, right?

Yes.

> Can you tell me
> which files it has come from so I can add it to the commit message?

lib/list_sort.c for all the list_sort stuff,
include/linux/list.h for the rest of the list_* stuff,
include/linux/kernel.h for container_of.

> Maybe it would be better to keep the list sorting code in it's own
> file (e.g. libxfs/list_sort.c) just to keep a bit of separation
> between the xfs code and code that is copied in from outside?

I'd wondered if it made more sense to do that, but (sort of arbitrarily
decided not to add more files).

--D

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>