| To: | Felix Janda <felix.janda@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/4] Remove off64_t from linux.h |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 20 Jun 2016 12:04:14 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160618145238.GA17768@nyan> |
| References: | <20160618145238.GA17768@nyan> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sat, Jun 18, 2016 at 04:52:38PM +0200, Felix Janda wrote: > The off64_t type is usually only conditionally exposed under the > feature test macro _LARGEFILE64_SOURCE (also defined by _GNU_SOURCE). > To make the public xfs headers more standalone therefore off64_t should > be avoided. "more standalone"? What does that mean? And what does it mean for all the xfsprogs code that still uses off64_t? i.e. if you are going to make xfsprogs fail to compile on configs that don't define off64_t, then it makes no sense to leave all the users of off64_t in the xfsprogs code.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 006/119] xfs: port differences from xfsprogs libxfs, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 4/4] Move to more stdint types, Dave Chinner |
| Previous by Thread: | [PATCH 1/4] Remove off64_t from linux.h, Felix Janda |
| Next by Thread: | Re: [PATCH 1/4] Remove off64_t from linux.h, Felix Janda |
| Indexes: | [Date] [Thread] [Top] [All Lists] |