xfs
[Top] [All Lists]

Re: [PATCH 005/119] xfs: check for a valid error_tag in errortag_add

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 005/119] xfs: check for a valid error_tag in errortag_add
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Jun 2016 04:34:42 -0700
Cc: david@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, vishal.l.verma@xxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <146612630452.12839.3528211000490660021.stgit@xxxxxxxxxxxxxxxx>
References: <146612627129.12839.3827886950949809165.stgit@xxxxxxxxxxxxxxxx> <146612630452.12839.3528211000490660021.stgit@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Thu, Jun 16, 2016 at 06:18:24PM -0700, Darrick J. Wong wrote:
> Currently we don't check the error_tag when someone's trying to set up
> error injection testing.  If userspace passes in a value we don't know
> about, send back an error.  This will help xfstests to _notrun a test
> that uses error injection to test things like log replay.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>