xfs
[Top] [All Lists]

Re: [PATCH v6 0/8] block: prepare for multipage bvecs

To: Ming Lei <ming.lei@xxxxxxxxxxxxx>
Subject: Re: [PATCH v6 0/8] block: prepare for multipage bvecs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 1 Jun 2016 06:44:27 -0700
Cc: Mike Snitzer <snitzer@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, "open list:DRBD DRIVER" <drbd-dev@xxxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Joe Thornber <ejt@xxxxxxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, NeilBrown <neilb@xxxxxxxx>, Sagi Grimberg <sagig@xxxxxxxxxxxx>, Shaohua Li <shli@xxxxxx>, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, "open list:XFS FILESYSTEM" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CACVXFVM9FqZFkMat_4ysJ8_vFd1FFnf6Bd9sHDDoCK=v93wViQ@xxxxxxxxxxxxxx>
References: <1464615294-9946-1-git-send-email-ming.lei@xxxxxxxxxxxxx> <20160531155348.GA24840@xxxxxxxxxx> <CACVXFVM9FqZFkMat_4ysJ8_vFd1FFnf6Bd9sHDDoCK=v93wViQ@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote:
> > be dm-crypt.c.  Maybe you've identified some indirect use of
> > BIO_MAX_SIZE?
> 
> I mean the recently introduced BIO_MAX_SIZE in -next tree:
> 
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/md/dm-crypt.c?id=4ed89c97b0706477b822ea2182827640c0cec486

The crazy bcache bios striking back once again.  I really think it's
harmful having a _MAX value and then having a minor driver
reinterpreting it and sending larger ones.  Until we can lift the
maximum limit in general nad have common code exercise it we really need
to stop bcache from sending these instead of littering the tree with
workarounds.

<Prev in Thread] Current Thread [Next in Thread>