| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v5 1/2] libxcmd: generalize topology functions |
| From: | "Bill O'Donnell" <billodo@xxxxxxxxxx> |
| Date: | Thu, 12 May 2016 07:20:39 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160512115513.GD32528@xxxxxxxxxxxxx> |
| References: | <1463006717-6104-1-git-send-email-billodo@xxxxxxxxxx> <1463006717-6104-2-git-send-email-billodo@xxxxxxxxxx> <20160512115513.GD32528@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.6.0 (2016-04-01) |
On Thu, May 12, 2016 at 04:55:13AM -0700, Christoph Hellwig wrote: > I still think libxfs would be the better place, but otherwise this looks > fine in general. > > > +#ifdef ENABLE_BLKID > > +# include <blkid/blkid.h> > > +#endif /* ENABLE_BLKID */ > > +#include "xfs_multidisk.h" > > But what tree is this against? I can't find a xfs_multidisk.h in > the master branch, nor in this patch? xfs_multidisk.h came about a few days ago (4a32b9e928b80) git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs: remove unused variable warning in xfs_finish_page_writeback, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] mkfs.xfs: annotate fallthrough cases in cvtnum, Carlos Maiolino |
| Previous by Thread: | Re: [PATCH v5 1/2] libxcmd: generalize topology functions, Christoph Hellwig |
| Next by Thread: | Re: [PATCH v5 1/2] libxcmd: generalize topology functions, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |