| To: | Bill O'Donnell <billodo@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v5 1/2] libxcmd: generalize topology functions |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 12 May 2016 04:55:13 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1463006717-6104-2-git-send-email-billodo@xxxxxxxxxx> |
| References: | <1463006717-6104-1-git-send-email-billodo@xxxxxxxxxx> <1463006717-6104-2-git-send-email-billodo@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
I still think libxfs would be the better place, but otherwise this looks fine in general. > +#ifdef ENABLE_BLKID > +# include <blkid/blkid.h> > +#endif /* ENABLE_BLKID */ > +#include "xfs_multidisk.h" But what tree is this against? I can't find a xfs_multidisk.h in the master branch, nor in this patch? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfs_quota: check report_mount return value, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfs: remove unused variable warning in xfs_finish_page_writeback, Christoph Hellwig |
| Previous by Thread: | [PATCH v5 1/2] libxcmd: generalize topology functions, Bill O'Donnell |
| Next by Thread: | Re: [PATCH v5 1/2] libxcmd: generalize topology functions, Bill O'Donnell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |