Re: [PATCH 2/3] block: require write_same and discard requests align to

xfs

Re: [PATCH 2/3] block: require write_same and discard requests align to

To:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject:	Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 13 Apr 2016 07:23:08 -0700
Cc:	axboe@xxxxxxxxx, hch@xxxxxxxxxxxxx, tytso@xxxxxxx, martin.petersen@xxxxxxxxxx, snitzer@xxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, bfoster@xxxxxxxxxx, xfs@xxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20160413040135.10562.74550.stgit@xxxxxxxxxxxxxxxx>
References:	<20160413040121.10562.98998.stgit@xxxxxxxxxxxxxxxx> <20160413040135.10562.74550.stgit@xxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.24 (2015-08-30)

On Tue, Apr 12, 2016 at 09:01:35PM -0700, Darrick J. Wong wrote:
> Make sure that the offset and length arguments that we're using to
> construct WRITE SAME and DISCARD requests are actually aligned to the
> logical block size.  Failure to do this causes other errors in other
> parts of the block layer or the SCSI layer because disks don't support
> partial logical block writes.

FYI, Bart has just been posting a patchset in that includes this, but
goes further.  Can you take a look at it?

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[RFC DONOTMERGE v8 0/3] fallocate for block devices, Darrick J. Wong [PATCH 2/3] block: require write_same and discard requests align to logical block size, Darrick J. Wong Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size, Christoph Hellwig <= [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Darrick J. Wong [PATCH 3/3] block: implement (some of) fallocate for block devices, Darrick J. Wong [PATCH 4/3] block: test fallocate for block devices, Darrick J. Wong

Previous by Date:	Re: ext4 error, Toshi Kani
Next by Date:	Re: [PATCH v2 1/5] dax: add dax_get_unmapped_area for pmd mappings, Toshi Kani
Previous by Thread:	[PATCH 2/3] block: require write_same and discard requests align to logical block size, Darrick J. Wong
Next by Thread:	[PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT., Darrick J. Wong
Indexes:	[Date] [Thread] [Top] [All Lists]