| To: | Shyam Kaushik <shyam@xxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: XFS hung task in xfs_ail_push_all_sync() when unmounting FS after disk failure/recovery |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 12 Apr 2016 18:19:35 +1000 |
| Cc: | Alex Lyakas <alex@xxxxxxxxxxxxxxxxx>, Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <0cfd6b7bfb3ef9dbac02a19a1f8fe568@xxxxxxxxxxxxxx> |
| References: | <f049419a2ab10f8e3c4fef0e4f4ca1ba@xxxxxxxxxxxxxx> <20160322121922.GA53693@xxxxxxxxxxxxxxx> <232dd85fde11d4ef1625f070eabfd167@xxxxxxxxxxxxxx> <20160408224648.GD567@dastard> <CAOcd+r0s3FfahxaqfJKuZ_D+0FbUHaKqi8b_bwGbXekCN3w_oQ@xxxxxxxxxxxxxx> <20160411012127.GF567@dastard> <0cfd6b7bfb3ef9dbac02a19a1f8fe568@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 12, 2016 at 12:29:48PM +0530, Shyam Kaushik wrote: > Hi Dave, > > I posted the patch. > > After applying this patch & your use-after-free patch, > xfs_ail_push_all_sync() processing intent-logs that are no longer relevant > upon disk failure/recovery doesn't happen anymore. I tried several times > to recreate and the issue doesn't show up. OK, so that confirms we are leaking inodes at that spot. I'll have a look at the patch.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: list_add corruption after "xfs: mode di_mode to vfs inode", Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH] xfs: Abort intent log item in xfs_iflush() upon error to get buf, Dave Chinner |
| Previous by Thread: | RE: XFS hung task in xfs_ail_push_all_sync() when unmounting FS after disk failure/recovery, Shyam Kaushik |
| Next by Thread: | Re: Internal error at xfs_trans_cancel, Avi Kivity |
| Indexes: | [Date] [Thread] [Top] [All Lists] |