| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/6] xfs: fix inode validity check in xfs_iflush_cluster |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 7 Apr 2016 16:43:17 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1460072271-23923-2-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1460072271-23923-1-git-send-email-david@xxxxxxxxxxxxx> <1460072271-23923-2-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Fri, Apr 08, 2016 at 09:37:46AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> Some careless idiot(*) wrote crap code in commit 1a3e8f3 ("xfs:
> convert inode cache lookups to use RCU locking") back in late 2010,
> and so xfs_iflush_cluster checks the wrong inode for whether it is
> still valid under RCU protection. Fix it to lock and check the
> correct inode.
Looks fine,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 5/6] xfs: xfs_inode_free() isn't RCU safe, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 2/6] xfs: rename variables in xfs_iflush_cluster for clarity, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/6] xfs: fix inode validity check in xfs_iflush_cluster, Dave Chinner |
| Next by Thread: | [PATCH 6/6] xfs: mark reclaimed inodes invalid earlier, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |