| To: | Eryu Guan <guaneryu@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] fs: return EPERM on immutable inode |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 6 Apr 2016 06:44:30 +1000 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, Steven Whitehouse <swhiteho@xxxxxxxxxx>, Bob Peterson <rpeterso@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "supporter:XFS FILESYSTEM" <xfs@xxxxxxxxxxx>, "open list:GFS2 FILE SYSTEM" <cluster-devel@xxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1459862890-22957-1-git-send-email-guaneryu@xxxxxxxxx> |
| References: | <1459862890-22957-1-git-send-email-guaneryu@xxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 05, 2016 at 09:28:10PM +0800, Eryu Guan wrote: > In most cases, EPERM is returned on immutable inode, and there're only > a few places returning EACCES. And EPERM looks more reasonable to me. > > So converting all EACCES to EPERM on immutable inode. > > Signed-off-by: Eryu Guan <guaneryu@xxxxxxxxx> > --- > > I noticed this when running LTP on overlayfs, setxattr03 failed due to > unexpected EACCES on immutable inode. This should be in the commit message itself, rather than "EPERM looks more reasonable". Other than that, change seems fine to me. Acked-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: xfs_iext_realloc_indirect and "XFS: possible memory allocation deadlock", Dave Chinner |
|---|---|
| Next by Date: | Re: support RCU lookups for inline symlinks, Dave Chinner |
| Previous by Thread: | [PATCH] fs: return EPERM on immutable inode, Eryu Guan |
| Next by Thread: | [PATCH v2] fs: return EPERM on immutable inode, Eryu Guan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |