xfs
[Top] [All Lists]

Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_B

To: Ming Lei <ming.lei@xxxxxxxxxxxxx>
Subject: Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 31 Mar 2016 00:52:28 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Boaz Harrosh <boaz@xxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Jens Axboe <axboe@xxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, drbd-dev@xxxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CACVXFVNtphY8bWrdMKcR7jYn5hD=H5H6jXrY111K0kZ8jJQHWw@xxxxxxxxxxxxxx>
References: <1459354637-17415-1-git-send-email-ming.lei@xxxxxxxxxxxxx> <1459354637-17415-3-git-send-email-ming.lei@xxxxxxxxxxxxx> <20160330171927.GA13320@xxxxxxxxxxxxx> <CACVXFVNtphY8bWrdMKcR7jYn5hD=H5H6jXrY111K0kZ8jJQHWw@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Thu, Mar 31, 2016 at 09:02:59AM +0800, Ming Lei wrote:
> That way may cause trouble to blk_type.h because it needs bvec_iter,
> then looks not good to always include bvec_iter.h into blk_type.h.

I'd expect bvec.h to be always included in blk_types.h, and replace
the inclusion of blk_types.h in fs.h eventually.

<Prev in Thread] Current Thread [Next in Thread>