xfs
[Top] [All Lists]

Re: [PATCH] xfs: don't hand out pNFS layouts for reflink inodes

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] xfs: don't hand out pNFS layouts for reflink inodes
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Wed, 30 Mar 2016 10:40:26 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160330172634.GA22951@xxxxxx>
References: <1456936485-21940-1-git-send-email-hch@xxxxxx> <20160328195140.GB5360@xxxxxxxxxxxxxxxx> <20160329072128.GA14940@xxxxxx> <20160330000842.GD5822@xxxxxxxxxxxxxxxx> <20160330172634.GA22951@xxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 30, 2016 at 07:26:34PM +0200, Christoph Hellwig wrote:
> On Tue, Mar 29, 2016 at 05:08:42PM -0700, Darrick J. Wong wrote:
> > > Btw, we'll need something similar to prevent swapfiles which just use
> > > ->bmap, but unfortunately swap just checks for the existences of method,
> > > so I'll probably have to do some VFS changes to properly support that.
> > 
> > Yes, please.  ocfs2 will gladly let you call swapon on a reflinked file,
> > and totally fails to CoW it properly. :)
> 
> Ouch.  Time to add a test for that to xfstests..

Swap/reflink tests will appear as generic/92[34] the next time I post xfstests
patches.

--D

<Prev in Thread] Current Thread [Next in Thread>