| To: | Vishal Verma <vishal@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 29 Mar 2016 23:56:46 -0700 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Jan Kara <jack@xxxxxxx>, linux-nvdimm@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, Jens Axboe <axboe@xxxxxx>, linux-mm@xxxxxxxxx, Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Al Viro <viro@xxxxxxxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1459320877.4102.3.camel@xxxxxxxxxx> |
| References: | <1459303190-20072-1-git-send-email-vishal.l.verma@xxxxxxxxx> <1459303190-20072-6-git-send-email-vishal.l.verma@xxxxxxxxx> <20160330063415.GA2132@xxxxxxxxxxxxx> <1459320877.4102.3.camel@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Wed, Mar 30, 2016 at 12:54:37AM -0600, Vishal Verma wrote: > On Tue, 2016-03-29 at 23:34 -0700, Christoph Hellwig wrote: > > Hi Vishal, > > > > still NAK to calling the direct I/O code directly from the dax code. > > Hm, I thought this was what you meant -- do the fallback/retry attempts > at the callers of dax_do_io instead of the new dax wrapper function.. > Did I misunderstand you? Sorry, it is. I misread fs/block_dev.c as fs/dax.c before my first coffee this morning. I'll properly review the series in the afternoon.. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io, Vishal Verma |
|---|---|
| Next by Date: | Re: [PATCH 4/5] dax: use sb_issue_zerout instead of calling dax_clear_sectors, Jan Kara |
| Previous by Thread: | Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io, Vishal Verma |
| Next by Thread: | [PATCH v2 3/5] dax: enable dax in the presence of known media errors (badblocks), Vishal Verma |
| Indexes: | [Date] [Thread] [Top] [All Lists] |