| To: | Ming Lei <ming.lei@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 29 Mar 2016 00:29:33 -0700 |
| Cc: | Jens Axboe <axboe@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, drbd-dev@xxxxxxxxxxxxxxxx, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Boaz Harrosh <boaz@xxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1458627149-12988-6-git-send-email-ming.lei@xxxxxxxxxxxxx> |
| References: | <1458627149-12988-1-git-send-email-ming.lei@xxxxxxxxxxxxx> <1458627149-12988-6-git-send-email-ming.lei@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
> + nr_pages = BIO_MAX_PAGES;
> if (nr_pages > total_nr_pages)
> nr_pages = total_nr_pages;
Looks reasonable, but the whole thing could simply become:
nr_pages = min(total_nr_pages, BIO_MAX_PAGES);
|
| Previous by Date: | Re: [PATCH 4/8] iov_iter: use bvec iterator to implement iterate_bvec(), Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 6/8] block: bio: remove BIO_MAX_SECTORS, Christoph Hellwig |
| Previous by Thread: | [PATCH 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES, Ming Lei |
| Next by Thread: | [PATCH 6/8] block: bio: remove BIO_MAX_SECTORS, Ming Lei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |