| To: | Ming Lei <ming.lei@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 29 Mar 2016 00:26:17 -0700 |
| Cc: | Jens Axboe <axboe@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, drbd-dev@xxxxxxxxxxxxxxxx, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Boaz Harrosh <boaz@xxxxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1458627149-12988-2-git-send-email-ming.lei@xxxxxxxxxxxxx> |
| References: | <1458627149-12988-1-git-send-email-ming.lei@xxxxxxxxxxxxx> <1458627149-12988-2-git-send-email-ming.lei@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
> --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -31,6 +31,7 @@ > > /* struct bio, bio_vec and BIO_* flags are defined in blk_types.h */ > #include <linux/blk_types.h> > +#include <linux/bvec_iter.h> > > #define BIO_DEBUG > > @@ -40,10 +41,6 @@ > #define BIO_BUG_ON > #endif > > -#define BIO_MAX_PAGES 256 > -#define BIO_MAX_SIZE (BIO_MAX_PAGES << PAGE_CACHE_SHIFT) > -#define BIO_MAX_SECTORS (BIO_MAX_SIZE >> 9) I see no reason why these should be moved out of bio.h. Otherwise this looks fine to me. |
| Previous by Date: | Re: [PATCH] xfs: don't hand out pNFS layouts for reflink inodes, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h, Ming Lei |
| Next by Thread: | Re: [PATCH 1/8] block: move bvec iterator into include/linux/bvec_iter.h, Ming Lei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |