Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing

xfs

Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing
From:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date:	Mon, 28 Mar 2016 15:05:06 -0700
Cc:	Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20160310141913.GC29058@xxxxxxxxxxxxx>
References:	<1457410578-30233-1-git-send-email-david@xxxxxxxxxxxxx> <1457410578-30233-6-git-send-email-david@xxxxxxxxxxxxx> <20160310141913.GC29058@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Mar 10, 2016 at 06:19:13AM -0800, Christoph Hellwig wrote:
> On Tue, Mar 08, 2016 at 03:16:07PM +1100, Dave Chinner wrote:
> > From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
> > 
> > For the rmap btree to work, we have to fed the extent owner
> 
> s/fed/feed/

<nod>

> 
> > +/*
> > + * Ownership info for an extent.  This is used to create reverse-mapping
> > + * entries.
> > + */
> > +#define XFS_RMAP_INO_ATTR_FORK     (1)
> > +#define XFS_RMAP_BMBT_BLOCK        (2)
> 
> These are OR-able flags - it might make sense to define them as:
> 
> #define XFS_RMAP_INO_ATTR_FORK        (1 << 0)
> #define XFS_RMAP_BMBT_BLOCK   (1 << 1)
> 
> to make this more obvious.

Ok.  Will do when I merge the "separate xfs_rmap_irec flags field" patch
into the appropriate patches (like this one).

--D

> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, (continued) Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Dave Chinner Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Christoph Hellwig [PATCH 01/16] xfs: introduce rmap btree definitions, Dave Chinner [PATCH 08/16] xfs: add rmap btree growfs support, Dave Chinner [PATCH 07/16] xfs: define the on-disk rmap btree format, Dave Chinner [PATCH 15/16] xfs: add rmap btree insert and delete helpers, Dave Chinner [PATCH 11/16] xfs: add rmap btree operations, Dave Chinner [PATCH 12/16] xfs: add tracepoints for the rmap-mirrors-bmbt functions, Dave Chinner [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Dave Chinner Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Christoph Hellwig Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Darrick J. Wong <= [PATCH 13/16] xfs: add an extent to the rmap btree, Dave Chinner [PATCH 10/16] xfs: rmap btree requires more reserved free space, Dave Chinner [PATCH 06/16] xfs: introduce rmap extent operation stubs, Dave Chinner [PATCH 09/16] xfs: rmap btree transaction reservations, Dave Chinner [PATCH 16/16] xfs: piggyback rmapbt update intents in the bmap free structure, Dave Chinner [PATCH 14/16] xfs: remove an extent from the rmap btree, Dave Chinner Re: [PATCH 0/16] xfs: first part of rmapbt functionality, Christoph Hellwig Re: [PATCH 0/16] xfs: first part of rmapbt functionality, Darrick J. Wong Re: [PATCH 0/16] xfs: first part of rmapbt functionality, Dave Chinner Re: [PATCH 0/16] xfs: first part of rmapbt functionality, Darrick J. Wong

Previous by Date:	Re: Build regressions/improvements in v4.6-rc1, Dave Chinner
Next by Date:	Re: Build regressions/improvements in v4.6-rc1, Darrick J. Wong
Previous by Thread:	Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Christoph Hellwig
Next by Thread:	[PATCH 13/16] xfs: add an extent to the rmap btree, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]