Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 10 Mar 2016 06:22:07 -0800
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1457410578-30233-4-git-send-email-david@xxxxxxxxxxxxx>
References:	<1457410578-30233-1-git-send-email-david@xxxxxxxxxxxxx> <1457410578-30233-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.24 (2015-08-30)

Sorry for the second reply to the same mail - I expect this defintion to
be in patch 7, where it logically belongs..

> +#define      XFS_RMAP_BLOCK(mp) \
>       (xfs_sb_version_hasfinobt(&((mp)->m_sb)) ? \
>        XFS_FIBT_BLOCK(mp) + 1 : \
>        XFS_IBT_BLOCK(mp) + 1)

Is there any good reason for the variable offset for the rmap block.
Yes, it saves one otherwise unused block per AG, but fixed offsets
for metadata make a format much easier to understand.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/16] xfs: first part of rmapbt functionality, Dave Chinner [PATCH 02/16] xfs: add rmap btree stats infrastructure, Dave Chinner [PATCH 04/16] libxfs: rearrange xfs_bmap_add_free parameters, Dave Chinner Re: [PATCH 04/16] libxfs: rearrange xfs_bmap_add_free parameters, Christoph Hellwig [PATCH 03/16] xfs: rmap btree add more reserved blocks, Dave Chinner Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Christoph Hellwig Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Christoph Hellwig <= Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Dave Chinner Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Christoph Hellwig [PATCH 01/16] xfs: introduce rmap btree definitions, Dave Chinner [PATCH 08/16] xfs: add rmap btree growfs support, Dave Chinner [PATCH 07/16] xfs: define the on-disk rmap btree format, Dave Chinner [PATCH 15/16] xfs: add rmap btree insert and delete helpers, Dave Chinner [PATCH 11/16] xfs: add rmap btree operations, Dave Chinner [PATCH 12/16] xfs: add tracepoints for the rmap-mirrors-bmbt functions, Dave Chinner [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Dave Chinner Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Christoph Hellwig

Previous by Date:	Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Christoph Hellwig
Next by Date:	Re: [PATCH 0/16] xfs: first part of rmapbt functionality, Darrick J. Wong
Previous by Thread:	Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Christoph Hellwig
Next by Thread:	Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]