Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 10 Mar 2016 06:19:13 -0800
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1457410578-30233-6-git-send-email-david@xxxxxxxxxxxxx>
References:	<1457410578-30233-1-git-send-email-david@xxxxxxxxxxxxx> <1457410578-30233-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.24 (2015-08-30)

On Tue, Mar 08, 2016 at 03:16:07PM +1100, Dave Chinner wrote:
> From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
> 
> For the rmap btree to work, we have to fed the extent owner

s/fed/feed/

> +/*
> + * Ownership info for an extent.  This is used to create reverse-mapping
> + * entries.
> + */
> +#define XFS_RMAP_INO_ATTR_FORK       (1)
> +#define XFS_RMAP_BMBT_BLOCK  (2)

These are OR-able flags - it might make sense to define them as:

#define XFS_RMAP_INO_ATTR_FORK  (1 << 0)
#define XFS_RMAP_BMBT_BLOCK     (1 << 1)

to make this more obvious.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, (continued) Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Christoph Hellwig Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Dave Chinner Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Christoph Hellwig [PATCH 01/16] xfs: introduce rmap btree definitions, Dave Chinner [PATCH 08/16] xfs: add rmap btree growfs support, Dave Chinner [PATCH 07/16] xfs: define the on-disk rmap btree format, Dave Chinner [PATCH 15/16] xfs: add rmap btree insert and delete helpers, Dave Chinner [PATCH 11/16] xfs: add rmap btree operations, Dave Chinner [PATCH 12/16] xfs: add tracepoints for the rmap-mirrors-bmbt functions, Dave Chinner [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Dave Chinner Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Christoph Hellwig <= Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Darrick J. Wong [PATCH 13/16] xfs: add an extent to the rmap btree, Dave Chinner [PATCH 10/16] xfs: rmap btree requires more reserved free space, Dave Chinner [PATCH 06/16] xfs: introduce rmap extent operation stubs, Dave Chinner [PATCH 09/16] xfs: rmap btree transaction reservations, Dave Chinner [PATCH 16/16] xfs: piggyback rmapbt update intents in the bmap free structure, Dave Chinner [PATCH 14/16] xfs: remove an extent from the rmap btree, Dave Chinner Re: [PATCH 0/16] xfs: first part of rmapbt functionality, Christoph Hellwig Re: [PATCH 0/16] xfs: first part of rmapbt functionality, Darrick J. Wong Re: [PATCH 0/16] xfs: first part of rmapbt functionality, Dave Chinner

Previous by Date:	Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Christoph Hellwig
Next by Date:	Re: [PATCH 03/16] xfs: rmap btree add more reserved blocks, Christoph Hellwig
Previous by Thread:	[PATCH 05/16] xfs: add owner field to extent allocation and freeing, Dave Chinner
Next by Thread:	Re: [PATCH 05/16] xfs: add owner field to extent allocation and freeing, Darrick J. Wong
Indexes:	[Date] [Thread] [Top] [All Lists]